Discussion:
[PATCH] bc: Add to pending
Add Reply
Gavin Howard
2018-07-06 01:59:24 UTC
Reply
Permalink
Hello,

Attached is a patch for adding my bc to toybox.

Gavin Howard
Gavin Howard
2018-08-07 15:22:21 UTC
Reply
Permalink
Hello,

Since it has been a month, I thought I would ping.

Gavin Howard
Post by Gavin Howard
Hello,
Attached is a patch for adding my bc to toybox.
Gavin Howard
Rob Landley
2018-08-07 22:14:38 UTC
Reply
Permalink
Post by Gavin Howard
Hello,
Since it has been a month, I thought I would ping.
I admit the drama circling around it's been a bit of a turn-off, but mostly I
just forgot. Let's see, why did I not add this immediately...

Because it adds tests/files/bc/{parse,print,arctan}.txt to .gitignore and if
anything goes in there it should be read only, so I had to remember to follow-up
with cleanups after applying it (otherwise it's easy to forget and stumble on it
a year later and wonder what else I missed)...

The tests all run in a scratch directory (if you "make test_bc" it should be
generated/testdir/testdir), so you can put generated files in the current
directory; generated/testdir gets blown away each time you run scripts/test.sh
and the "testdir" under it gets rm -rf'd and recreated between each test if
you're testing multiple commands.

I'll try to get to that this weekend, sorry for the delay.

Rob
Gavin Howard
2018-08-08 06:18:48 UTC
Reply
Permalink
Hello,

I thought I might be able to help with the changes. Attached is a
standalone patch (so ignore the previous one) that has the changes you
listed.

It also has a recent fix for a segfault on a random bit of invalid input,
as well as some warning fixes, in case you want those also.

Gavin Howard
Post by Rob Landley
Post by Gavin Howard
Hello,
Since it has been a month, I thought I would ping.
I admit the drama circling around it's been a bit of a turn-off, but mostly I
just forgot. Let's see, why did I not add this immediately...
Because it adds tests/files/bc/{parse,print,arctan}.txt to .gitignore and if
anything goes in there it should be read only, so I had to remember to follow-up
with cleanups after applying it (otherwise it's easy to forget and stumble on it
a year later and wonder what else I missed)...
The tests all run in a scratch directory (if you "make test_bc" it should be
generated/testdir/testdir), so you can put generated files in the current
directory; generated/testdir gets blown away each time you run
scripts/test.sh
and the "testdir" under it gets rm -rf'd and recreated between each test if
you're testing multiple commands.
I'll try to get to that this weekend, sorry for the delay.
Rob
_______________________________________________
Toybox mailing list
http://lists.landley.net/listinfo.cgi/toybox-landley.net
Loading...