Discussion:
my current patch queue
(too old to reply)
Georgi Chorbadzhiyski
2012-03-09 14:45:45 UTC
Permalink
Rob, I buried you with patches lately. Here is what I'm currently sitting on.

Ignore OS X and Android patches for now, do not waste time on them. I'll
revisit them once _GNU_SOURCE stops moving around :) From these patches
probably
- Use fprintf(stderr, ...) instead of dprintf() should be used.

FIXES branch: https://github.com/gfto/toybox/compare/master...fixes
- Contains three new toys - md5sum, test and logger.
- md5sum and test are ports from public domain code, logger is written
by me.
- Also in here - a fix for id, fix for current toys/sleep breakage,
added <strings.h> in toybox.h.
- Added _GNU_SOURCE again in portability.h so I can compile toys/unshare.
- Replace strndupa in mdev.

MUSL branch: https://github.com/gfto/toybox/compare/master...musl
- This branch is obsolete if the following patches are applied:
- Add <strings.h> in toybox.h.
- Add _GNU_SOURCE again in portability.h
- Replace strndupa in mdev.

CHMOD branch: https://github.com/gfto/toybox/compare/master...chmod

Implements chmod, chown and chgrp. Adds dirtree_for_each() in lib/
Should be non controversial.

WARN branch: https://github.com/gfto/toybox/compare/master...warn
- These are needed:
- toys/mke2fs: Remove unused variables.
- kconfig/mconf: Fix warnings.

It quite a mess on my side but if I can do something to help you waste less
time on the aforementioned patches I'll be happy to.

P.S. I hope you don't mind I'm using git. I have tried hg for toybox, but
my work habits are very much git oriented.
--
Georgi Chorbadzhiyski
http://georgi.unixsol.org/
Rob Landley
2012-03-10 02:32:09 UTC
Permalink
Post by Georgi Chorbadzhiyski
Rob, I buried you with patches lately. Here is what I'm currently sitting on.
Looks good. Sorry I'm taking so much time to catch up but work's been
needy recently. Luckily,there is the weekend...
Post by Georgi Chorbadzhiyski
It quite a mess on my side but if I can do something to help you waste less
time on the aforementioned patches I'll be happy to.
I just have to grind through it. I'm halfway through a cleanup of tail,
halfway through a C implementation of config2help, halfway through a
triage of the sed spec to implement that, and I have 31 email messages
marked as unread in the toybox folder.

Plus I'd like to cut another release this weekend, since the last one
was slightly broken. (Missing generated/help.h from the tarball.)
Post by Georgi Chorbadzhiyski
P.S. I hope you don't mind I'm using git. I have tried hg for toybox, but
my work habits are very much git oriented.
git's fine, we've tried to do a git mirror here using hg-git but
couldn't make it work. (In theory mercurial can bidirectinally
import/export from a git tree, if you can figure out how.)

How did you do the conversion?

Rib
Georgi Chorbadzhiyski
2012-03-10 02:36:21 UTC
Permalink
Post by Rob Landley
Post by Georgi Chorbadzhiyski
Rob, I buried you with patches lately. Here is what I'm currently sitting on.
Looks good. Sorry I'm taking so much time to catch up but work's been
needy recently. Luckily,there is the weekend...
Post by Georgi Chorbadzhiyski
It quite a mess on my side but if I can do something to help you waste less
time on the aforementioned patches I'll be happy to.
I just have to grind through it. I'm halfway through a cleanup of tail,
halfway through a C implementation of config2help, halfway through a
triage of the sed spec to implement that, and I have 31 email messages
marked as unread in the toybox folder.
Plus I'd like to cut another release this weekend, since the last one
was slightly broken. (Missing generated/help.h from the tarball.)
Post by Georgi Chorbadzhiyski
P.S. I hope you don't mind I'm using git. I have tried hg for toybox, but
my work habits are very much git oriented.
git's fine, we've tried to do a git mirror here using hg-git but
couldn't make it work. (In theory mercurial can bidirectinally
import/export from a git tree, if you can figure out how.)
How did you do the conversion?
I'm using git-hg [1] to track your repository. It is my local git master
branch. I just run git-hg pull from time to time to update master and
use topic branches for development. No problem at all so far.

[1]: https://github.com/offbytwo/git-hg
--
Georgi Chorbadzhiyski
http://georgi.unixsol.org/
Georgi Chorbadzhiyski
2012-03-10 02:36:21 UTC
Permalink
Post by Rob Landley
Post by Georgi Chorbadzhiyski
Rob, I buried you with patches lately. Here is what I'm currently sitting on.
Looks good. Sorry I'm taking so much time to catch up but work's been
needy recently. Luckily,there is the weekend...
Post by Georgi Chorbadzhiyski
It quite a mess on my side but if I can do something to help you waste less
time on the aforementioned patches I'll be happy to.
I just have to grind through it. I'm halfway through a cleanup of tail,
halfway through a C implementation of config2help, halfway through a
triage of the sed spec to implement that, and I have 31 email messages
marked as unread in the toybox folder.
Plus I'd like to cut another release this weekend, since the last one
was slightly broken. (Missing generated/help.h from the tarball.)
Post by Georgi Chorbadzhiyski
P.S. I hope you don't mind I'm using git. I have tried hg for toybox, but
my work habits are very much git oriented.
git's fine, we've tried to do a git mirror here using hg-git but
couldn't make it work. (In theory mercurial can bidirectinally
import/export from a git tree, if you can figure out how.)
How did you do the conversion?
I'm using git-hg [1] to track your repository. It is my local git master
branch. I just run git-hg pull from time to time to update master and
use topic branches for development. No problem at all so far.

[1]: https://github.com/offbytwo/git-hg
--
Georgi Chorbadzhiyski
http://georgi.unixsol.org/
Georgi Chorbadzhiyski
2012-03-09 14:45:45 UTC
Permalink
Rob, I buried you with patches lately. Here is what I'm currently sitting on.

Ignore OS X and Android patches for now, do not waste time on them. I'll
revisit them once _GNU_SOURCE stops moving around :) From these patches
probably
- Use fprintf(stderr, ...) instead of dprintf() should be used.

FIXES branch: https://github.com/gfto/toybox/compare/master...fixes
- Contains three new toys - md5sum, test and logger.
- md5sum and test are ports from public domain code, logger is written
by me.
- Also in here - a fix for id, fix for current toys/sleep breakage,
added <strings.h> in toybox.h.
- Added _GNU_SOURCE again in portability.h so I can compile toys/unshare.
- Replace strndupa in mdev.

MUSL branch: https://github.com/gfto/toybox/compare/master...musl
- This branch is obsolete if the following patches are applied:
- Add <strings.h> in toybox.h.
- Add _GNU_SOURCE again in portability.h
- Replace strndupa in mdev.

CHMOD branch: https://github.com/gfto/toybox/compare/master...chmod

Implements chmod, chown and chgrp. Adds dirtree_for_each() in lib/
Should be non controversial.

WARN branch: https://github.com/gfto/toybox/compare/master...warn
- These are needed:
- toys/mke2fs: Remove unused variables.
- kconfig/mconf: Fix warnings.

It quite a mess on my side but if I can do something to help you waste less
time on the aforementioned patches I'll be happy to.

P.S. I hope you don't mind I'm using git. I have tried hg for toybox, but
my work habits are very much git oriented.
--
Georgi Chorbadzhiyski
http://georgi.unixsol.org/
Rob Landley
2012-03-10 02:32:09 UTC
Permalink
Post by Georgi Chorbadzhiyski
Rob, I buried you with patches lately. Here is what I'm currently sitting on.
Looks good. Sorry I'm taking so much time to catch up but work's been
needy recently. Luckily,there is the weekend...
Post by Georgi Chorbadzhiyski
It quite a mess on my side but if I can do something to help you waste less
time on the aforementioned patches I'll be happy to.
I just have to grind through it. I'm halfway through a cleanup of tail,
halfway through a C implementation of config2help, halfway through a
triage of the sed spec to implement that, and I have 31 email messages
marked as unread in the toybox folder.

Plus I'd like to cut another release this weekend, since the last one
was slightly broken. (Missing generated/help.h from the tarball.)
Post by Georgi Chorbadzhiyski
P.S. I hope you don't mind I'm using git. I have tried hg for toybox, but
my work habits are very much git oriented.
git's fine, we've tried to do a git mirror here using hg-git but
couldn't make it work. (In theory mercurial can bidirectinally
import/export from a git tree, if you can figure out how.)

How did you do the conversion?

Rib
Continue reading on narkive:
Loading...