Discussion:
[PATCH] Add "uudecode -o -" support.
(too old to reply)
enh
2017-04-03 21:14:34 UTC
Permalink
Raw Message
busybox uudecode supports this, and POSIX explicitly mentions it (albeit
only in the "STDOUT" section). Plus Android doesn't have /dev/stdout and
/dev/stdin, so this lets us rewrite the uudecode tests so they pass on
Android too.
---
tests/uudecode.test | 19 +++++++++----------
toys/posix/uudecode.c | 3 ++-
2 files changed, 11 insertions(+), 11 deletions(-)
enh
2017-04-10 19:03:44 UTC
Permalink
Raw Message
ping?
Post by enh
busybox uudecode supports this, and POSIX explicitly mentions it (albeit
only in the "STDOUT" section). Plus Android doesn't have /dev/stdout and
/dev/stdin, so this lets us rewrite the uudecode tests so they pass on
Android too.
---
tests/uudecode.test | 19 +++++++++----------
toys/posix/uudecode.c | 3 ++-
2 files changed, 11 insertions(+), 11 deletions(-)
--
Elliott Hughes - http://who/enh - http://jessies.org/~enh/
Android native code/tools questions? Mail me/drop by/add me as a reviewer.
Rob Landley
2017-04-11 03:06:45 UTC
Permalink
Raw Message
ping?
Sorry, drove back from Minneapolis to Austin over the weekend, didn't
get much programming done.

I had a window open on this one because it adds an explicit check for
"-" and I have openro() in xwrap.c and loopfiles_rw() both checking that
already, and I was trying to figure out if there's missing generic
infrastructure or if the patch should be tweaked, and that's where I got
distracted. :)

Checked in now. Composing a reply in a separate window about possible
architectural issues...

Rob
enh
2017-04-11 05:00:56 UTC
Permalink
Raw Message
Post by Rob Landley
ping?
Sorry, drove back from Minneapolis to Austin over the weekend, didn't
get much programming done.
I had a window open on this one because it adds an explicit check for
"-" and I have openro() in xwrap.c and loopfiles_rw() both checking that
already, and I was trying to figure out if there's missing generic
infrastructure or if the patch should be tweaked, and that's where I got
distracted. :)
yeah, i was surprised i couldn't find something suitable, but i gave up
when i grepped for strcmp.*"-" and found there were already more special
cases than i realized. seemed like a job for another day...
Post by Rob Landley
Checked in now. Composing a reply in a separate window about possible
architectural issues...
Rob
--
Elliott Hughes - http://who/enh - http://jessies.org/~enh/
Android native code/tools questions? Mail me/drop by/add me as a reviewer.
Loading...