Discussion:
[PATCH] Speed up tail.test for shells without builtin printf.
(too old to reply)
enh
2017-04-08 06:19:14 UTC
Permalink
Raw Message
The test only needs echo, and Android currently doesn't use mksh's
builtin printf; the toybox printf is fuller featured and less buggy,
but a lot slower to call in a loop like this (and mksh doesn't fall
back to the printf on the path if given something it can't handle,
so we can't have the best of both worlds).

Without this hack, the tail test takes as long as all the other
tests put together.
---
tests/tail.test | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
enh
2017-04-14 22:11:42 UTC
Permalink
Raw Message
ping?
Post by enh
The test only needs echo, and Android currently doesn't use mksh's
builtin printf; the toybox printf is fuller featured and less buggy,
but a lot slower to call in a loop like this (and mksh doesn't fall
back to the printf on the path if given something it can't handle,
so we can't have the best of both worlds).
Without this hack, the tail test takes as long as all the other
tests put together.
---
tests/tail.test | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
--
Elliott Hughes - http://who/enh - http://jessies.org/~enh/
Android native code/tools questions? Mail me/drop by/add me as a reviewer.
Loading...