Discussion:
[PATCH] Remove mount.test awk dependency.
(too old to reply)
enh
2017-04-03 15:35:30 UTC
Permalink
Raw Message
Parsing file(1) output isn't a good way to determine file system type
anyway.
---
tests/mount.test | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
Rob Landley
2017-04-07 16:47:09 UTC
Permalink
Raw Message
Post by enh
Parsing file(1) output isn't a good way to determine file system type
anyway.
The mount tests (which there need to be soooo many more of, there's
comments in mount.c about that) are one of the category of "tests really
needing mkroot" because:

A) Requires root to run.
B) Requires a host with known stuff on it to test
C) Hard to clean up after if it fails.
D) Can potentially hose the system badly enough to require a reboot if
it goes wrong.

The other cannonical example of this is ifconfig. :)

(Possibly it could be done with containers instead of qemu, but
insmod.test can't. And although I finally figured out how to test ps, it
requires a --bind mount over /proc after the first few simple ones.)

Rob
enh
2017-04-07 16:50:54 UTC
Permalink
Raw Message
Yeah, but that's a big job for the future. I am root and can spin up a new
emulator instance and throw it away afterwards at very little cost (for
x86/x86-64). So it's still useful in the usual "half an eye is better than
no eye" sense.
Post by enh
Parsing file(1) output isn't a good way to determine file system type
anyway.
The mount tests (which there need to be soooo many more of, there's
comments in mount.c about that) are one of the category of "tests really
needing mkroot" because:

A) Requires root to run.
B) Requires a host with known stuff on it to test
C) Hard to clean up after if it fails.
D) Can potentially hose the system badly enough to require a reboot if
it goes wrong.

The other cannonical example of this is ifconfig. :)

(Possibly it could be done with containers instead of qemu, but
insmod.test can't. And although I finally figured out how to test ps, it
requires a --bind mount over /proc after the first few simple ones.)

Rob
Rob Landley
2017-04-07 22:00:49 UTC
Permalink
Raw Message
Post by enh
Yeah, but that's a big job for the future. I am root and can spin up a
new emulator instance and throw it away afterwards at very little cost
(for x86/x86-64). So it's still useful in the usual "half an eye is
better than no eye" sense.
Oh sure, I'm just saying I want to automate it a bit more. "Warning,
dangling plumbing in this area..." :)

Rob

Loading...